[Basic] Ensure empty NullTerminatedStringRef have valid pointer #65263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
requested review from
bnbarham and
DougGregor
and removed request for
hborla and
slavapestov
rintaro
force-pushed
the
nullterminatedstringref-rdar108215490
branch
3 times, most recently
from
538be7f to
21fda4e
Compare
NullterminatedStringRef is meant to be safe for reading 'data()' as a valid C-string. rdar://108215490
rintaro
force-pushed
the
nullterminatedstringref-rdar108215490
branch
from
21fda4e to
43eabf1
Compare
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
nullterminatedstringref-rdar108215490
branch
from
93d4fe4 to
4252148
Compare
bnbarham
approved these changes
Apr 18, 2023
rintaro
force-pushed
the
nullterminatedstringref-rdar108215490
branch
from
4252148 to
f8de332
Compare
rintaro
commented
Apr 19, 2023
lib/Sema/TypeCheckMacros.cpp
Outdated
Comment on lines
690
to
694
| std::string cachedDiscriminator; | ||
| auto getDiscriminator = [&]() -> StringRef { | ||
| if (!cachedDiscriminator.empty()) | ||
| return cachedDiscriminator; | ||
|
|
||
| LazyValue<std::string> discriminator([&]() -> std::string { |
There was a problem hiding this comment.
Don't we have similar "lazy" value thing in llvm or swiftBasic? 🤔
rintaro
force-pushed
the
nullterminatedstringref-rdar108215490
branch
from
f8de332 to
c4a4b58
Compare
|
@swift-ci Please smoke test |
Saves one memory copy. No need to create a temporary NullTerminatedStringRef.
rintaro
force-pushed
the
nullterminatedstringref-rdar108215490
branch
from
c4a4b58 to
a0eb32e
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullterminatedStringRefis meant to be safe for readingdata()as a valid C-string.rdar://108215490