Skip to content

[5.9] [Compiler plugins] Fix missing return along error-handling paths #65276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2023
Merged

[5.9] [Compiler plugins] Fix missing return along error-handling paths #65276

merged 2 commits into from
Apr 19, 2023

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Apr 19, 2023 •
edited
Loading

  • Explanation: When failing to load a compiler plugin, we correctly reported an error and then failed to return. This causes an assertion in asserting builds, and oddly random failures in non-asserting builds. Add the missing return.
  • Scope: Affects code using macros via shared library plugins.
  • Risk: Low, fix along an error path.
  • Issue: rdar://107797992
  • Original pull request: [Compiler plugins] Fix missing return along error-handling paths #65275

@DougGregor
[Compiler plugins] Fix missing return along error-handling paths
808db07 
Fixes a crash when we cannot load a compiler plugin for some reason,
tracked by rdar://107797992.
@DougGregor DougGregor requested a review from a team as a code owner April 19, 2023 01:06
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please clean test macOS

@DougGregor DougGregor merged commit ee61e11 into swiftlang:release/5.9 Apr 19, 2023
@DougGregor DougGregor deleted the load-plugin-missing-return-5.9 branch April 19, 2023 13:15
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DougGregor @hborla @AnthonyLatsis