[5.9][Serialization] Only read the underlying type of an opaque type if the function is inlinable #65296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nlinable Clients of a resilient module using opaque types don't need access to the underlying type unless it's used in an inlinable context. Plus, the underlying type can reference internal details which can lead to crashes when they reference implementation-only dependencies. To clean up this behavior, let's only serialize the underlying type if used by an inlinable function. rdar://105128784
When reading a swiftmodule that's part of the main module the compiler should have access to all internal details. In that case, read the underlying type to opaque types. This was caught by `SILOptimizer/specialize_opaque_result_types2.sil` which has a merge-module like behavior reading it sib files as input.
|
@swift-ci Please test |
nkcsgexi
approved these changes
Apr 19, 2023
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying type of an opaque type is defined inside the function body, as such its knowledge needs to be spread in a similar manner. Clients of a resilient module using opaque types don't need access to the underlying type unless it's used for an inlinable function. Plus, the underlying type can reference internal details which can lead to crashes when they reference implementation-only dependencies. To realign this behavior, let's only read the underlying type when the opaque type is on an inlinable function.
Bringing in to 5.9 as this issue has been affecting swift-api-extract and other workarounds aren't enough.
rdar://105128784
Cherry-pick of #64991