[interop][SwiftToCxx] do not assert when emitting non-resilient struc… #65352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts with opaque layout (cherry picked from commit e6e43c6)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts with opaque layout
(cherry picked from commit e6e43c6)
Explanation: Swift value types with opaque layout but who are not resilient should be emitted as types with opaque layout in the C++ section of the generated header. Right now this causes an assertion when generating a value type like this, but this assertion can be removed as we can handle this case correctly as we can generate an interface for a type with opaque layout.
Scope: Swift's and C++ interoperability, generated header generator.
Risk: Low.
Testing: Swift unit tests.
Reviewer: @zoecarver