Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry picks two bug fixes for SE-0365 into the Swift 5.9 release branch.
let self
condition would prevent using implicit self #65310 / [SE-0365] Allow implicit self in inner functions in [weak self] closures, like with [self] closures #65211 and shown below (I didn't see or file an issue or radar for these issues, I just fixed them once I found them)weak self
closures. There is little risk that this would cause a source compatibility issue, since these changes allow code that was previously rejected. It is also unlikely that this would cause a regression since there are pretty extensive unit tests for the expected behavior.I CP'd both of these changes in the same PR because the implementation of #65310 depends on changes in #65211
Examples of code that is currently rejected in Swift 5.8 / 5.9 but compiles successfully with these changes as expected by SE-0365: