5.9: [SILGen] Consuming a param implies it's eager-move. #65379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a parameter is marked consuming and its type is Copyable, that parameter has eager-move semantics. Apply that attribute to the SILFunctionArgument corresponding to the parameter. rdar://108385761
|
@swift-ci please test |
tbkka
approved these changes
Apr 22, 2023
The test/SILGen/consuming_parameter.swift already had its FileCheck lines updated for its consuming parameters to be eager-move when String was made eager-move on main. Apply the same change here now that consuming parameters are eager-move.
|
@swift-ci please test |
atrick
approved these changes
Apr 24, 2023
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #65377 .
If a parameter is marked consuming and its type is Copyable, that parameter has eager-move semantics. Apply that attribute to the
SILFunctionArgumentcorresponding to the parameter.rdar://108385761