Skip to content

[stdlib] Improve readability by replacing if let with guard let in lexicographicallyPrecedes method #65384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ojun9
Copy link
Contributor

@ojun9 ojun9 commented Apr 23, 2023

In the lexicographicallyPrecedes method, replace if let with guard let to decrease nesting levels and enhance readability.

@ojun9
Copy link
Contributor Author

ojun9 commented Apr 23, 2023

@swift-ci please test

@Azoy
Copy link
Contributor

Azoy commented Apr 25, 2023

This looks good to me! Let's run tests

@Azoy
Copy link
Contributor

Azoy commented Apr 25, 2023

@swift-ci please test

@ojun9
Copy link
Contributor Author

ojun9 commented Apr 26, 2023

@Azoy

Thank you for reviewing my pull request and running the CI tests. Since I don't have the authority to approve and merge the PR, could you please take care of it if everything looks good to you?
I appreciate your help! 💚

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this improvement!

@Azoy Azoy merged commit d90134c into swiftlang:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants