Replace several (test-)tool binaries with symlinks to swift-frontend #65387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://76551283
rdar://76551283
…ontend rdar://76551283
…tend rdar://76551283
|
@swift-ci smoke test |
edymtt
reviewed
Apr 24, 2023
| SOURCE "swift-frontend${CMAKE_EXECUTABLE_SUFFIX}" | ||
| DESTINATION "swift-llvm-opt${CMAKE_EXECUTABLE_SUFFIX}" | ||
| WORKING_DIRECTORY "${SWIFT_RUNTIME_OUTPUT_INTDIR}") | ||
|
|
There was a problem hiding this comment.
We would need to add the commands to install the symlinks, so that we don't drop those in the final toolchains.
This is a possible snippet to apply at the end of the file, together with the other installation commands.
Suggested change
| swift_install_in_component(FILES "${SWIFT_RUNTIME_OUTPUT_INTDIR}/sil-opt${CMAKE_EXECUTABLE_SUFFIX}" | |
| DESTINATION "bin" | |
| COMPONENT tools) | |
| swift_install_in_component(FILES "${SWIFT_RUNTIME_OUTPUT_INTDIR}/sil-func-extractor${CMAKE_EXECUTABLE_SUFFIX}" | |
| DESTINATION "bin" | |
| COMPONENT tools) | |
| swift_install_in_component(FILES "${SWIFT_RUNTIME_OUTPUT_INTDIR}/sil-nm${CMAKE_EXECUTABLE_SUFFIX}" | |
| DESTINATION "bin" | |
| COMPONENT tools) | |
| swift_install_in_component(FILES "${SWIFT_RUNTIME_OUTPUT_INTDIR}/sil-llvm-gen${CMAKE_EXECUTABLE_SUFFIX}" | |
| DESTINATION "bin" | |
| COMPONENT tools) | |
| swift_install_in_component(FILES "${SWIFT_RUNTIME_OUTPUT_INTDIR}/sil-passpipeline-dumper${CMAKE_EXECUTABLE_SUFFIX}" | |
| DESTINATION "bin" | |
| COMPONENT testsuite-tools) | |
| swift_install_in_component(FILES "${SWIFT_RUNTIME_OUTPUT_INTDIR}/swift-dependency-tool${CMAKE_EXECUTABLE_SUFFIX}" | |
| DESTINATION "bin" | |
| COMPONENT tools) | |
| swift_install_in_component(FILES "${SWIFT_RUNTIME_OUTPUT_INTDIR}/swift-llvm-opt${CMAKE_EXECUTABLE_SUFFIX}" | |
| DESTINATION "bin" | |
| COMPONENT tools) |
There was a problem hiding this comment.
(please double check I got the components right)
There was a problem hiding this comment.
@edymtt It's not the intention of this PR to install the symlinks. We can decide later if we want this.
If someone (a compiler engineer) needs such a tool in an installed toolchain he/she can easily create the symlink.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sil-optsil-func-extractorsil-nmsil-llvm-gensil-passpipeline-dumperswift-dependency-toolswift-llvm-optThis saves build time and disk space.
It also makes those (test-) tools available wherever the compiler itself is available
rdar://76551283