Skip to content

[Macros] Eliminate overaggressive cycle breaking in getSemanticAttrs() #65394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

[Macros] Eliminate overaggressive cycle breaking in getSemanticAttrs() #65394

merged 1 commit into from
Apr 25, 2023

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Apr 24, 2023 •
edited
Loading

  • Explanation: Eliminate an overly-aggressive cycle-break in the handling of "semantic" attributes for a given node, which caused some attributes introduced by member-attribute macros to not get processed. This is a narrow reversion of some problematic code.
  • Scope: Narrow; the code being reverted breaks some cycles in invalid code, but did so incorrectly.
  • Risk: Low, narrowly applied to macros.
  • Issue: rdar://108456284.
  • Reviewed by: @hborla
  • Original pull request: [Macros] Eliminate overaggressive cycle breaking in getSemanticAttrs() #65393

@DougGregor
[Macros] Eliminate overaggressive cycle breaking in getSemanticAttrs()
41cbf47 
This cycle break means that some attributes introduced by
member-attribute macros aren't getting processed. I'm still reducing a
test case while I look for a fix, but for now I'm reverting this
change to address a regression for macros.

Fixes rdar://108456284.
@DougGregor DougGregor requested a review from a team as a code owner April 24, 2023 17:50
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit 77cdb77 into swiftlang:release/5.9 Apr 25, 2023
@DougGregor DougGregor deleted the revert-semantic-attrs-cycle-break-5.9 branch April 25, 2023 00:50
@DougGregor DougGregor mentioned this pull request Apr 25, 2023
Merged
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DougGregor @nkcsgexi @AnthonyLatsis