[interop][SwiftToCxx] add additional type representation emission che… #65397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
…ck for associated enum element types This ensures that we do not try to emit enums whose associated values come from dependent modules that don't have a C++ representation
hyp
force-pushed
the
eng/enum-final-boss
branch
from
0206f2b to
7efae9a
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test windows platform |
| // we also need to perform additional check on whether the type can be | ||
| // emitted here as well, to ensure that we don't emit types from dependent | ||
| // modules that do not have a C++ representation. | ||
| for (const auto *enumCase : enumDecl->getAllCases()) { |
There was a problem hiding this comment.
Just going by the comment, is there any code duplication between the checks done in getDeclRepresentation and the checks here. Is there an opportunity to factor this out to a common helper function?
ravikandhadai
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ck for associated enum element types
This ensures that we do not try to emit enums whose associated values come from dependent modules that don't have a C++ representation
Also remove outdated FIXME for enum availability.