Sema: Ban shadowing generic parameters from outer scopes #65400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Apr 25, 2023
|
@xedin Yep, I forgot to |
slavapestov
force-pushed
the
generic-param-shadowing
branch
from
a0b2fc6 to
a005cf1
Compare
|
I figured as much :) |
slavapestov
force-pushed
the
generic-param-shadowing
branch
from
a005cf1 to
d633ec9
Compare
|
@swift-ci Please test source compatibility |
Code like that is usually indicative of programmer error, and does not round-trip through module interface files since there is no source syntax to refer to an outer generic parameter. For source compatibility this is a warning, but becomes an error with -swift-version 6. Fixes rdar://problem/108385980 and swiftlang#62767.
slavapestov
force-pushed
the
generic-param-shadowing
branch
from
d633ec9 to
290701c
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code like that is usually indicative of programmer error, and does not round-trip through module interface files since there is no source syntax to refer to an outer generic parameter.
For source compatibility this is a warning, but becomes an error with -swift-version 6.
Fixes rdar://problem/108385980 and #62767.