Skip to content

[interop][SwiftToCxx] do not assert when emitting a public var and fu… #65401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

[interop][SwiftToCxx] do not assert when emitting a public var and fu… #65401

merged 1 commit into from
Apr 28, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Apr 24, 2023

…nction with the same C++ name

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Apr 24, 2023
@hyp hyp requested a review from ravikandhadai April 24, 2023 21:06
@hyp hyp requested review from zoecarver and egorzhdan as code owners April 24, 2023 21:06
@hyp
Copy link
Contributor Author

hyp commented Apr 24, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Apr 24, 2023

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Apr 24, 2023

@swift-ci please test

2 similar comments
@hyp
Copy link
Contributor Author

hyp commented Apr 25, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Apr 25, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Apr 25, 2023

@swift-ci please test source compatibility

@hyp hyp merged commit 82eb493 into swiftlang:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravikandhadai ravikandhadai ravikandhadai approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @ravikandhadai