Add support for nested ASTScopes inside of macro expansions. #65403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch the parents of SILDebugScopes representing macro expansions were missing the inlinedAt field, which resulted in incorrent LLVM IR being produced. This is fixed by first computing the inlined call site for a macro expansion and then computing the nested SILDebugScope for the ASTScope of the expanded nodes; adding the inlinedAt field to all of levels of parent scopes. rdar://108323748
|
@swift-ci test |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch the parents of SILDebugScopes representing macro expansions were missing the inlinedAt field, which resulted in incorrent LLVM IR being produced. This is fixed by first computing the inlined call site for a macro expansion and then computing the nested SILDebugScope for the ASTScope of the expanded nodes; adding the inlinedAt field to all of levels of parent scopes.
rdar://108323748
Cherry pick of #65402.