[Macros] Improve breaking of cyclic references for member-attribute macros #65410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are likely to debugging more cyclic references involving macros in the future, so improve the diagnostics to specify what operation we're performing (e.g., macro resolution vs. expansion of a particular kind of macro) and the macro name, when possible, so failures are easier to diagnose. No functionality change for well-formed code.
…acro is attached The macro-resolution request for an attached macro was expressed in terms of the custom attribute and the declaration context enclosing the attribute. While the declaration context is the correct one for resolving the types and arguments of the custom attribute, the declaration provides a better anchor for cases where the same attribute applies to multiple declarations, e.g., with member-attribute macros, leading to false cyclic references.
…mber attributes The last step in breaking the cycle through visible declaration lookup, e.g., with invalid code. Prior to this, we would get a false cyclic reference through the parameters of a function when they try to find property wrappers on the parameters.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a more effective cyclic-reference breaking strategy for macros in ill-formed code, reinstating the test case that was recently disabled as part of #65393. There are two pieces to this strategy:
ResolveMacroRequestso we don't have false collisions for member-attribute macrosWhile here, improve the diagnostics we get when macro resolution or expansion introduces a cyclic reference, because we're likely to see more of these.