Skip to content

SIL: Bridge 'any Sendable' via the id-as-Any path [5.9] #65414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

SIL: Bridge 'any Sendable' via the id-as-Any path [5.9] #65414

merged 1 commit into from
Apr 26, 2023

Conversation

slavapestov
Copy link
Contributor

  • Description: We introduced a new Clang attribute to bridge Objective-C parameter and return types as 'Sendable', but this wasn't plumbed through, so calling such a method from Swift would pass the address of the Swift existential as id, causing a crash on the Objective-C side. This patch handles this case via the "id as Any" code path, performing the correct bridging.
  • Risk: Low; this generalizes the "isAny()" check in two places to also allow existentials containing only marker protocols.
  • Reviewed by: @DougGregor
  • Radar: Fixes rdar://problem/107264240.

@slavapestov slavapestov requested a review from a team as a code owner April 25, 2023 16:13
@slavapestov
SIL: Bridge 'any Sendable' via the id-as-Any path
ddce01f 
Fixes rdar://problem/107264240.
@slavapestov slavapestov force-pushed the bridging-id-as-any-sendable-5.9 branch from fde1ebb to ddce01f Compare April 25, 2023 17:56
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov slavapestov merged commit c2a096b into swiftlang:release/5.9 Apr 26, 2023
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slavapestov @hborla @AnthonyLatsis