[Sanitizers] Remove obsolete LIT substitution #65420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
yln
commented
Apr 27, 2023
| # variable which enforces the usage of iOS8+ when iOS is used. | ||
| config.substitutions.append(('%sanitizers-target-triple', | ||
| config.variant_triple.replace("ios7", "ios8"))) | ||
|
|
There was a problem hiding this comment.
Eric, can you confirm that the minimum deployment target in Swift tests is >= iOS 8?
@edymtt
There was a problem hiding this comment.
For all intent and purposes, yes:
- the default iOS target in build-script and CMake has been bumped to 11.0
- Xcode 13.0 (the oldest we support in build-script) effectively supports iOS 9.0 and later
edymtt
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this LIT substitution was to ensure we compile test binaries for iOS with an deployment target of >= iOS 8.