[Macros] Automatically format expanded macros #65450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
rintaro,
zoecarver and
CodaFi
as code owners
bnbarham
force-pushed
the
format-macro-expansions
branch
from
980e45e to
a3242ce
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
format-macro-expansions
branch
from
a3242ce to
ee30220
Compare
|
Random fly-by that I love this :-) ❤️ |
bnbarham
force-pushed
the
format-macro-expansions
branch
from
ee30220 to
07f7857
Compare
Heh, thanks :). Just to set expectations - this is in no way meant to be a complete format. It's mostly just to avoid having to manually add eg. required spaces. Basic indentation isn't too bad on top of that, so that's in there too. |
|
Yeah that's already quite helpful :) Looks good! |
|
@swift-ci please test |
DougGregor
approved these changes
Apr 27, 2023
bnbarham
force-pushed
the
format-macro-expansions
branch
from
07f7857 to
8304410
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Apr 27, 2023
Rather than requiring macro implementations to add required whitespace and indentation, basic format all macro expansions. Right now this uses the default four space indentation, we can consider having that inferred later. Macros can opt-out of automatic formatting by implementing `formatMode` and setting it to `.disabled`. Also moves the extra newlines before/after expansions to a new "Inline Macro" refactoring. Resolves rdar://107731047.
bnbarham
force-pushed
the
format-macro-expansions
branch
from
8304410 to
fe2104c
Compare
|
@swift-ci please test |
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than requiring macro implementations to add required whitespace and indentation, basic format all macro expansions. Right now this uses the default four space indentation, we can consider having that inferred later. Macros can opt-out of automatic formatting by implementing
formatModeand setting it to.disabled.Also moves the extra newlines before/after expansions to a new "Inline Macro" refactoring.
Resolves rdar://107731047.