[NFC] Fix issue-61440 test formatting #65454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
LucianoPAlmeida
changed the title
| } | ||
|
|
||
| struct S:P // expected-error {{type 'S' does not conform to protocol 'P'}} | ||
| struct S: P // expected-error {{type 'S' does not conform to protocol 'P'}} |
There was a problem hiding this comment.
Not that it really matters but one space before a trailing comment in enough.
There was a problem hiding this comment.
Thanks for taking on the issue! Line breaks before
{are still inconsistent though; could you fix that?Please consider using more idiomatic and descriptive commit messages. For example,
Fix test formatting after #<pull request id>.
Got it, will do in my next PR!
slavapestov
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test as part of fixing #61440 but the format was slightly irregular. Fixed the formatting of the test. @slavapestov Sorry, was not able to fix the test in the prior PR
Related: #65434