Sema: Improve diagnostics for overrides of unavailable decls #65456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unavailable decls cannot be overridden by available decls. This change improves the compiler diagnostics for this restriction in a few ways: - Duplicate diagnostics are suppressed for getters and setters inside property declarations that have already been diagnosed. - Diagnostics are suppressed for implicit accessors since they would typically duplicate diagnostics for the explicit accessors the implicit ones are derived from. - Decls inside unavailable a derived class are no longer incorrectly diagnosed.
tshortli
requested review from
hborla,
slavapestov,
xedin and
AnthonyLatsis
as code owners
|
@swift-ci please test |
Comment on lines
+2115
to
+2117
| auto unavailabilityStatusAndAttr = | ||
| checkOverrideUnavailability(override, base); | ||
| auto *unavailableAttr = unavailabilityStatusAndAttr.second; |
There was a problem hiding this comment.
Nit: If we are in c++ 17 maybe we could use structured binding here =]
Suggested change
| auto unavailabilityStatusAndAttr = | |
| checkOverrideUnavailability(override, base); | |
| auto *unavailableAttr = unavailabilityStatusAndAttr.second; | |
| auto [status, unavailableAttr] = | |
| checkOverrideUnavailability(override, base); |
There was a problem hiding this comment.
That does seem nicer. I'm not going to revise this solely for that right now but I'll keep an eye out for opportunities to improve readability with this syntax in the future now that the project uses C++17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unavailable decls cannot be overridden by available decls. This change improves the compiler diagnostics for this restriction in a few ways: