[5.9][interop] avoid importing math functions from the C++ standard library #65498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They cause ambiguities with math functions from platform's libc
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They cause ambiguities with math functions from platform's libc
Explanation: The math functions like pow, sin, abs etc. from C++ standard library get imported into Swift when C++ interop is enabled. This causes ambiguities for users when they're already using such math functions from Darwin/GLibc C modules or from Swift's standard library itself. For now let's not import such functions to Swift, using a heuristic that checks if the function is from one of the known libc++/libstdc++ header.
Scope: Swift's and C++ interoperability, Clang importer.
Risk: Low.
Testing: Swift unit tests, and manual testing on some Swift packages.
Reviewer: @ravikandhadai