[CodeComplete] Offer completions for the names: argument of a macro declaration
#65521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… declaration When completing after `names:`, completion should offer the different ways you can specify the names, i.e. `arbitrary`, `named`, etc. ``` @freestanding(declaration, names: #^COMPLETE^#) ``` rdar://108535077
ahoppen
requested review from
CodaFi,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
1 similar comment
|
@swift-ci Please smoke test macOS |
bnbarham
reviewed
May 1, 2023
Comment on lines
+101
to
+102
| // NOTE: When adding a new name kind, also add it to | ||
| // `getAllMacroIntroducedDeclNameKinds`. |
There was a problem hiding this comment.
I haven't looked at all the uses of MacroIntroducedDeclNameKind, could we have a Last equivalent rather than the vector?
There was a problem hiding this comment.
Discussed offline and couldn’t come up with a betters solution than the std::vector
bnbarham
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When completing after
names:, completion should offer the different ways you can specify the names, i.e.arbitrary,named, etc.@attached(member, names: #^COMPLETE^#)rdar://108535077