Sema: Inherit SPI groups when synthesizing modify accessor #65542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
xedin
reviewed
May 1, 2023
xedin
approved these changes
May 1, 2023
xymus
approved these changes
May 1, 2023
slavapestov
reviewed
May 1, 2023
nkcsgexi
approved these changes
May 1, 2023
Resolves rdar://108069565
Properties may have `@_spi` setters and therefore the exportability of a referenced accessor may differ from the exportability of the storage.
tshortli
force-pushed
the
implicit-modify-inherit-spi
branch
from
91ac9f1 to
f11eaf1
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When synthesizing a
_modifycoroutine for a property, ensure the implicit declaration gets the same SPI groups as the property setter since they should have the same visibility.Additionally, diagnose the exportability of references to accessors. Previously resilience type checking assumed that accessors always have the same exportability as their storage, but with
@_spiaccessors this is no longer the case.Resolves rdar://108069565