Remove a stateful workaround for Property Wrappers. #65554
Merged
+31
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
force-pushed
the
107030837-5.9
branch
from
55cd6c7 to
9019589
Compare
|
@swift-ci test |
adrian-prantl
changed the title
In an earlier version of the ASTScope -> SILdebugScope translation a workaround was put into place that would select the current debug scope if an ASTScope was marked as ignoreInDebugInfo. Removing this workaround makes the translation more predictable as it eliminated the dependency on the current SILBuilder state. The property wrapper tests still pass without this. This uncovers a situations with let bindings where the SIL instructions are emitted RHS before LHS, which does violate the di-hole verifier. This is addressed by relaxing the verifier for now. rdar://108736443 (cherry picked from commit dcd881e)
adrian-prantl
force-pushed
the
107030837-5.9
branch
from
9019589 to
d59c9ee
Compare
|
@swift-ci test |
|
@swift-ci test macos |
jckarter
approved these changes
May 2, 2023
fredriss
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an earlier version of the ASTScope -> SILdebugScope translation a wrokaround was put into place that would select the current debug scope if an ASTScope was marked as ignoreInDebugInfo. Removing this workaround makes the translation more predictable as it eliminated the dependency on the current SILBuilder state. The result builder tests still pass without this.
rdar://108736443
(cherry picked from commit f038410)