ASTMangler: Fix mangling of SILFunctionType with @pack conventions [5.9] #65561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slavapestov
commented
May 1, 2023
slavapestov
commented
- Description: We incorrectly mangled SILFunctionTypes, which only appear in debug info. The symptom was an assertion failure in demangling.
- Risk: Low, changes the mangling for variadic generics only
- Reviewed by: @hborla
- Radar: rdar://problem/107151125.
- Tested: Added a test case.
hborla
approved these changes
May 1, 2023
Fixes rdar://problem/107151125.
slavapestov
force-pushed
the
sil-function-type-pack-mangling-5.9
branch
from
0315691 to
49087d0
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.