Skip to content

Revert "[SwiftSyntax] Verify swift-syntax code gen" #65563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 1, 2023

This is causing failures on Linux nodes, e.g. https://ci.swift.org/job/oss-swift-RA-linux-ubuntu-18_04-long-test/3820/console

Reverts #65439

@ahoppen ahoppen requested a review from kimdv May 1, 2023 23:25
@ahoppen
Copy link
Member Author

ahoppen commented May 1, 2023

@swift-ci Please smoke test

@artemcm artemcm merged commit 0ce6d06 into main May 1, 2023
@artemcm artemcm deleted the revert-65439-kimdv/use-local-git-repo-for-code-gen branch May 1, 2023 23:29
@ahoppen
Copy link
Member Author

ahoppen commented May 1, 2023

@kimdv I think we hit this problem because #65439 was not tested in conjunction with swiftlang/swift-syntax#1546 in the end. I think the underlying problem is that we didn’t set SWIFTCI_USE_LOCAL_DEPS in run_code_generation.

@kimdv
Copy link
Contributor

kimdv commented May 2, 2023

@ahoppen does that need to be set from CI side or inside the build-script?

@ahoppen
Copy link
Member Author

ahoppen commented May 2, 2023

It just needs to be set in swift-syntax/build-script.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants