Skip to content

Revert #64269 #65568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2023
Merged

Revert #64269 #65568

merged 2 commits into from
May 2, 2023

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented May 2, 2023

Older compilers that we aim to support with textual interfaces don't understand @expression but do understand $Macros so falling back to @expression when $FreestandingExpressionMacros is not available causes a condfail. Revert #64269 and just require users to have a relatively recent compiler if they want to work with the expression macros in the standard library.

Resolves rdar://108591384

@tshortli
Copy link
Contributor Author

tshortli commented May 2, 2023

@swift-ci please smoke test

@tshortli tshortli requested a review from DougGregor May 2, 2023 02:47
@tshortli tshortli changed the title Revert https://github.com/apple/swift/pull/64269/ Revert #64269 May 2, 2023
@tshortli tshortli mentioned this pull request May 2, 2023
@tshortli
Copy link
Contributor Author

tshortli commented May 2, 2023

@swift-ci please smoke test macOS

@tshortli tshortli merged commit 9496125 into swiftlang:main May 2, 2023
@tshortli tshortli deleted the expression-attr-condfail branch May 2, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant