[CodeComplete] Offer code completion for attached macro attributes #65572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to teach code completion how to invoke the type checker for attached macro attributes. After that, everything started working. rdar://105232015
ahoppen
requested review from
bnbarham,
rintaro,
hborla,
slavapestov and
xedin
as code owners
bnbarham
approved these changes
May 2, 2023
hamishknight
reviewed
May 2, 2023
| @@ -3258,17 +3258,17 @@ void simple_display(llvm::raw_ostream &out, | |||
| class ResolveMacroRequest | |||
| : public SimpleRequest<ResolveMacroRequest, | |||
| ConcreteDeclRef(UnresolvedMacroReference, | |||
| const Decl *), | |||
| DeclContext *), | |||
There was a problem hiding this comment.
I believe this was changed to take a Decl instead of DeclContext to avoid cycles (4f6ab4b), is that no longer an issue?
There was a problem hiding this comment.
I just talked to @DougGregor and he agrees that this might not be necessary. Tests also seem to be passing locally for me.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to teach code completion how to invoke the type checker for attached macro attributes. After that, everything started working.
rdar://105232015