Support std::unique_ptr.
#65577
Closed
Support std::unique_ptr.
#65577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
hyp
reviewed
May 2, 2023
| import StdUniquePtr | ||
| #if os(Linux) | ||
| import CxxStdlib | ||
| // FIXME: import CxxStdlib.string once libstdc++ is split into submodules. |
There was a problem hiding this comment.
That's not going to happen. Can you just import CxxStdlib?
There was a problem hiding this comment.
We have a bunch of existing tests that do this, I'll update them to just import CxxStdlib.
|
@swift-ci please test |
|
@swift-ci please test windows |
|
Shall we guard move only types on libc++ for the time being or try to fix the libstdc++ issue? |
|
@swift-ci please test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the synthesized members consume but that's OK for now. At least it's correct.