[cxx-interop] Disable rvalue references. We don't support them correc… #65578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly (leading to lifetime issues). We are missing a consuming.
|
@swift-ci please test |
|
Also what about rvalue this. I guess that can be disabled in a follow-up. |
Yeah it would also be hard for a user to call an rvalue method from Swift anyway |
…ointee type in Swift even if parameter's type is type alias This finally allows std::vector.push_back to be called with the pushed value directly passed into it
hyp
requested review from
ravikandhadai
and removed request for
xedin,
slavapestov and
hborla
lib/ClangImporter/ImportType.cpp
Outdated
| @@ -2356,12 +2356,17 @@ ClangImporter::Implementation::importParameterType( | |||
| dyn_cast<clang::TemplateTypeParmType>(paramTy)) { | |||
| swiftParamTy = findGenericTypeInGenericDecls( | |||
| *this, templateParamType, genericParams, attrs, addImportDiagnosticFn); | |||
| } else if (auto refType = dyn_cast<clang::ReferenceType>(paramTy)) { | |||
| } else if (auto refType = dyn_cast<clang::ReferenceType>(paramTy)) { | |||
There was a problem hiding this comment.
Looks like we introduced some whitespace at the end here.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
zoecarver
commented
May 4, 2023
Comment on lines
+22
to
+23
| let _42: CInt = 42 | ||
| v.push_back(_42) |
There was a problem hiding this comment.
can we just inline this literal as we do below?
There was a problem hiding this comment.
Yeah I can do that in a followup. Also need to disable this for template functions too in a follow up.
zoecarver
commented
May 4, 2023
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tly (leading to lifetime issues). We are missing a consuming.