Skip to content

[interop] update <swift/bridging> to have language comment and __has_attribute guard #65589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2023
Merged

[interop] update <swift/bridging> to have language comment and __has_attribute guard #65589

merged 2 commits into from
May 3, 2023

Conversation

hyp
Copy link
Contributor

@hyp hyp commented May 2, 2023

  • [interop] <swift/bridging> guard macros using has_attribute to make this header usable with GCC and MSVC
  • [interop] <swift/bridging> header should have a language comment line for IDE recognition

@hyp hyp added the c++ interop Feature: Interoperability with C++ label May 2, 2023
@hyp hyp requested a review from ravikandhadai May 2, 2023 17:50
@hyp hyp requested review from zoecarver and egorzhdan as code owners May 2, 2023 17:50
@hyp
Copy link
Contributor Author

hyp commented May 2, 2023

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented May 2, 2023

@swift-ci please test source compatibility

egorzhdan
egorzhdan approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyp hyp merged commit 3e89c4d into swiftlang:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@ravikandhadai ravikandhadai Awaiting requested review from ravikandhadai

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyp @egorzhdan