Skip to content

[5.9] Macros: Escape init when printing names for attached macros #65603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented May 2, 2023

Cherry-pick of #65602.

Older compilers can't parse name(init). Restore the call to escapeKeywordInContext() to ensure special names get escaped.

Resolves rdar://108806697

@tshortli tshortli requested a review from a team as a code owner May 2, 2023 23:24
@tshortli
Copy link
Contributor Author

tshortli commented May 2, 2023

@swift-ci please test

Older compilers can't parse `name(init)`. Restore the call to
`escapeKeywordInContext()` to ensure special names get escaped.

Resolves rdar://108806697
@tshortli tshortli force-pushed the attached-macro-condfail-5.9 branch from e5bd6c8 to ca2013e Compare May 3, 2023 00:46
@tshortli tshortli changed the title [5.9] Macros: Escape init and subscript when printing names for attached macros [5.9] Macros: Escape init when printing names for attached macros May 3, 2023
@tshortli
Copy link
Contributor Author

tshortli commented May 3, 2023

@swift-ci please test

@tshortli tshortli merged commit 7d934ed into swiftlang:release/5.9 May 3, 2023
@tshortli tshortli deleted the attached-macro-condfail-5.9 branch May 3, 2023 06:47
@tshortli tshortli added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants