[diags][cxx-interop] Update diagnostic for 'begin' to suggest using a for-loop instead. #65617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for-loop instead. Does not fix the fix-it. The current fix it will be left as a stop-gap solution and we can hopefully update this fix it in the near future to actually plop in a for loop (too much work for this PR though).
zoecarver
requested review from
hyp,
egorzhdan,
hborla,
xedin and
slavapestov
as code owners
|
@swift-ci please test |
hyp
approved these changes
May 3, 2023
xedin
reviewed
May 3, 2023
| @@ -195,7 +195,7 @@ NOTE(mark_safe_to_import, none, "annotate method '%0' with 'SWIFT_RETURNS_INDEPE | |||
| NOTE(at_to_subscript, none, "do you want to replace it with a call " | |||
| "to the subscript operator?", | |||
| ()) | |||
| NOTE(get_swift_iterator, none, "do you want to make a Swift iterator instead?", | |||
| NOTE(use_collection_apis, none, "do you want to use a for-loop instead?", | |||
There was a problem hiding this comment.
Maybe for-in loop is better? That's how that construct is referred to in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not fix the fix-it. The current fix it will be left as a stop-gap solution and we can hopefully update this fix it in the near future to actually plop in a for loop (too much work for this PR though).
It's important to change this wording ASAP so that people aren't lead astray.