[IRGen] Check for nil in final class cast opt. #65636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an optimization, there is a fast-cast to non-final classes that just compares isa pointers. If the source of the cast is an Optional<class>, though, it's not allowed to "directly compare the isa-pointer"; because the source might be Optional.none, i.e. null. Add a check for nil when emitting the fast class cast. rdar://108614878
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an optimization, there is a fast-cast to final classes that just compares isa pointers. If the source of the cast is an
Optional<class>, though, it's not allowed to "directly compare the isa-pointer"; because the source might beOptional.none, i.e.null.Add a check for
nullwhen emitting the fast class cast.rdar://108614878