[5.9][CodeComplete] Offer completion suggestions for default argument values inside the macro declaration + argument label inside #externalMacro
#65638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es inside the macro declaration We were not type checking the default argument initializer because `MacroDecl` is not an `AbstractFucntionDecl`. Add `MacroDecl` to the list of nodes we know how to get parameters from. rdar://108163564
…Macro` rdar://108163809 rdar://108681394
ahoppen
changed the title
#externalMacro
airspeedswift
approved these changes
May 4, 2023
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacroDeclis not anAbstractFucntionDecl. AddMacroDeclto the list of nodes we know how to get parameters from.Pretty much unrelated, but also a small change in the same test file: Continue checking a
#externalMacrodeclaration in code completion mode even if the argument labels don’t match. This way we get completion results for#externalMacroargument labels and when competing after#whenexternalMacrois already specified.#externalMacro#65526