[5.9][ConstraintSystem] Reverse direction of ShapeOf constraint
#65657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
approved these changes
May 4, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #65625
Explanation:
Changes directionality of the
ShapeOfconstraint to better fit and fixes one place in simplification logic whereShapeOfwas used incorrectly:ShapeOf- First type is the reduced shape of the second type (the pack type).ShapeOfinstead ofExplicitGenericArguments.Scope: Expressions that use variadic generics feature.
Main Branch PR: [ConstraintSystem] Reverse direction of
ShapeOfconstraint #65625Resolves: (There are no issues for this discovered via code review).
Risk: Extra Low.
Reviewed By: @hborla
Testing: Added regression test-cases to the suite.