[5.9] Pick new diagnostic for unsafe 'begin' methods: suggest using for loop. #65659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for-loop instead. Does not fix the fix-it. The current fix it will be left as a stop-gap solution and we can hopefully update this fix it in the near future to actually plop in a for loop (too much work for this PR though).
|
Presumably you'll pick #65658 to 5.9 later as well right :) |
I was just going to let that land on main and be picked up whenever. I don't think it's a big deal, but I can incorporate it if you want. |
Sure, I don't have a strong opinion there. |
|
@swift-ci please test |
DougGregor
approved these changes
May 4, 2023
|
Closing this PR as this is not essential for 5.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: 'begin' is one of the most commonly used methods that returns an iterator. We should lead Swift users towards using the collection/sequence API interface, not the Swift iterator interface. This is a UX improvement that we want in 5.9.
Testing: Swift unit tests, manual testing.
Scope: Swift's and C++ interoperability, diagnostics
Risk: extra-low. This only changes the text of a diagnostic; this is a non-functional change.
Reviewers: @hyp @xedin