Sema: Fix incorrect assert in TypeCheckProtocol.cpp. #65667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
AnthonyLatsis,
hborla and
slavapestov
as code owners
|
@swift-ci please test |
slavapestov
approved these changes
May 4, 2023
We can't assume that we will always find a viable witness for a protocol requirement when typechecking a `.swiftinterface` file. The assert that assumed there would be a match could fail when building a broken interface or building a valid interface with a broken SDK, causing crashes instead of emitting diagnostics. Resolves rdar://108688535
tshortli
force-pushed
the
swiftinterface-missing-conformance-req-assert
branch
from
787c18a to
ba422f9
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't assume that we will always find a viable witness for a protocol requirement when typechecking a
.swiftinterfacefile. The assert that assumed there would be a match could fail when building a broken interface or building a valid interface with a broken SDK, causing crashes instead of emitting diagnostics.Resolves rdar://108688535