Skip to content

[5.9] Two @objcImpl protocol fixes #65685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2023

Conversation

beccadax
Copy link
Contributor

@beccadax beccadax commented May 5, 2023

Cherry-pick of #65641 to release/5.9:

Fixes two issues with @_objcImplementation and protocols specified in the header file:

  • IRGen was incorrectly walking the implementation context instead of the imported interface to emit conformances.
  • TypeCheckDeclObjC was insisting on having an implementation for protocol requirements even when they were marked @optional on the ObjC side.

Fixes rdar://108482165 and rdar://108461441.

@beccadax beccadax requested a review from a team as a code owner May 5, 2023 02:35
@beccadax
Copy link
Contributor Author

beccadax commented May 5, 2023

@swift-ci please test

@beccadax beccadax merged commit 4d2ce8a into swiftlang:release/5.9 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants