_forget usage fixes to match SE-390
#65690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
kavon
changed the title
_forget usage fixes to match SE-390
we decided against allowing it for now. rdar://108877261
rdar://108877261
kavon
force-pushed
the
forget-usage-fixes
branch
2 times, most recently
from
a4c651a to
ea16bc4
Compare
We haven't quite got the semantics we want implemented for `discard` aka `_forget` statements. Allowing people to use `_forget` in noncopyable types that have stored properties that require destruction will not let us implement it the way we'd like in the future without source break. But, if the type only has "trivial" stored properties with a no-op destruction, like `Int`, then we can still provide utility for users like FileDescriptor who just want to disable the deinit and have nothing fancy stored in the type itself. rdar://108877261
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a bundle of fixes for the
_forgetstatement in terms of its legal usages to match the conclusions of SE-390 review. The changes are detailed in each commit.rdar://108877261