Skip to content

[Serialization] Teach ASTSectionImporter to filter by triple. #65725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023

Conversation

adrian-prantl
Copy link
Contributor

On macOS it is possible for one application to contain Swift modules compiled for different triples that are incompatible as far as the Swift compiler is concerned. Examples include an iOS simulator application hunning on a macOS host, or a macCatalyst application running on macOS. A debugger might see .swift_ast sections for all triples at the same time. This patch adds an interface to let the client provide a triple to filter Swift modules in an ASTSection.

rdar://107869141

Same as #65724

@adrian-prantl
Copy link
Contributor Author

test with swiftlang/llvm-project#6797
@swift-ci test

2 similar comments
@adrian-prantl
Copy link
Contributor Author

test with swiftlang/llvm-project#6797
@swift-ci test

@adrian-prantl
Copy link
Contributor Author

test with swiftlang/llvm-project#6797
@swift-ci test

On macOS it is possible for one application to contain Swift modules compiled
for different triples that are incompatible as far as the Swift compiler is
concerned. Examples include an iOS simulator application hunning on a macOS
host, or a macCatalyst application running on macOS. A debugger might see
.swift_ast sections for all triples at the same time. This patch adds an
interface to let the client provide a triple to filter Swift modules in an
ASTSection.

rdar://107869141
@adrian-prantl
Copy link
Contributor Author

test with swiftlang/llvm-project#6797
@swift-ci test

@adrian-prantl adrian-prantl merged commit fd06d27 into swiftlang:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant