[5.9][interop][SwiftToCxx] add swift::String overlay constructor for const… #65754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructing it directly from a C string literal resolves swiftlang#63448
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ructing it directly from a C string literal
resolves #63448
Explanation: It was not possible to construct
swift::Stringtype that represents Swift's String type in C++ from a C++ string literal / C string. This change adds a new C++ constructor to this type to ensure that it can be implicitly constructed from a string literal / C string.Scope: Swift's and C++ interoperability, Swift's standard library overlay for C++.
Risk: Low. This type is not adopted yet in C++ adopters.
Testing: Swift unit tests, manual testing on some adopter projects and several Swift packages that import C.
PR: #65683
Reviewer: @egorzhdan