🍒 [5.9][Constant Evaluator] Enable SILConstants::setIndexedElement function to work with aggregates containing unknown values #65770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to work with aggregates containing unknown values. Such aggregates can be generated when an instruction is skipped during constant evaluation and its results are used to create a struct.
|
@swift-ci please smoke test |
devincoughlin
approved these changes
May 8, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such aggregates can be generated when an instruction is skipped during constant evaluation and its results are used to create a struct.
Original PR
Explanation: Compiler can crashes in passes using constant evaluator when evaluation encounters certain SIMD types.
Scope: Swift programs that use SIMD instructions along with the
os_logAPIs.Risk: Low, this changes relaxes an assertion in an internal function of constant evaluator and instead returns an error in such cases, which is already gracefully handled by the constant evaluator.
Testing: Swift and SIL LIT tests. This PR landed in main for a while.
Reviewers: @matthewseaman and @kulpreetchilana
rdar://107344820