Skip to content

Sema: Suppress explicit availability diagnostics on non-Darwin targets #65772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented May 8, 2023

Suggesting the addition of an @available attribute on Linux and Windows is inapprorpriate given that Swift is not ABI stable on those platforms.

Resolves rdar://107387133

@tshortli tshortli requested a review from xymus May 8, 2023 19:25
@tshortli tshortli force-pushed the suppress-explicit-availability-diags-non-darwin branch from f06b0a5 to 530bfef Compare May 8, 2023 20:42
Suggesting the addition of an `@available` attribute on Linux and Windows is
inapprorpriate given that Swift is not ABI stable on those platforms.

Resolves rdar://107387133
@tshortli tshortli force-pushed the suppress-explicit-availability-diags-non-darwin branch from 530bfef to 93a96e8 Compare May 8, 2023 21:53
@tshortli
Copy link
Contributor Author

tshortli commented May 8, 2023

@swift-ci please smoke test

Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes a lot of sense!

@tshortli tshortli merged commit e12e16d into swiftlang:main May 9, 2023
@tshortli tshortli deleted the suppress-explicit-availability-diags-non-darwin branch May 9, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants