[Runtime] Immediate release and return when destroying partial instance of pure ObjC class. #65776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckarter
approved these changes
May 8, 2023
|
@swift-ci please test and merge |
al45tair
approved these changes
May 9, 2023
al45tair
reviewed
May 9, 2023
| // on. There are no ivar destroyers. This avoids attempting to mutate | ||
| // placeholder objects statically created in read-only memory. | ||
| if (classMetadata->isPureObjC()) { | ||
| objc_release((id)object); |
There was a problem hiding this comment.
Hmmm. Looks like this file somehow doesn't include the definition of id; seems odd that it's got objc_release(), but not id.
There was a problem hiding this comment.
Oh silly me, this needs to be guarded by OBJC_INTEROP too.
…ce of pure ObjC class. Make swift_deallocPartialClassInstance check if the object's class is a pure ObjC class, in which case there are no ivar destroyers and we can just return immediately. It's possible for an allocWithZone: override to cause self to be a special object constructed in read-only memory. swift_deallocPartialClassInstance calls object_setClass to avoid running the dealloc method of any Swift subclasses, but this call crashes if self is read-only. It's unnecessary when the object's class is pure ObjC and therefore there are no Swift subclasses, so just skip it entirely. rdar://107756747
mikeash
force-pushed
the
dealloc-partial-class-instance-setclass-readonly
branch
from
90e1e0a to
3a396af
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make swift_deallocPartialClassInstance check if the object's class is a pure ObjC class, in which case there are no ivar destroyers and we can just return immediately.
It's possible for an allocWithZone: override to cause self to be a special object constructed in read-only memory. swift_deallocPartialClassInstance calls object_setClass to avoid running the dealloc method of any Swift subclasses, but this call crashes if self is read-only. It's unnecessary when the object's class is pure ObjC and therefore there are no Swift subclasses, so just skip it entirely.
rdar://107756747