Fix covariant erasure for constrained existentials #65785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela-laar
requested review from
hborla,
slavapestov,
xedin and
AnthonyLatsis
as code owners
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
from
53ab11f to
b7ea961
Compare
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
from
b7ea961 to
4014438
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
slavapestov
reviewed
May 9, 2023
xedin
reviewed
May 9, 2023
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
2 times, most recently
from
f78b63c to
b3d3263
Compare
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
2 times, most recently
from
4eb2968 to
d900dcd
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
from
d900dcd to
8a4f965
Compare
|
@swift-ci please smoke test |
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
from
32670ee to
7c16b27
Compare
|
@swift-ci please smoke test |
slavapestov
reviewed
May 11, 2023
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
from
7c16b27 to
68186ce
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
Looks like a test in |
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
from
fcbd2e1 to
c56f99e
Compare
Constrained existentials should be type erased to an upper bound that is dependent on other type parameters.
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
from
c56f99e to
b5400ba
Compare
|
@swift-ci please smoke test |
Opened existentials should be erased to the dependent upper bound if the dependent member can be reduced to a concrete type. This allows the generic signature to support parameterized protocol types and bound generic class types by producing a more specific constraint instead of just a plain protocol or class.
angela-laar
force-pushed
the
fix-covariant-erasure-for-constrained-existentials
branch
from
b5400ba to
a9f1096
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
xedin
approved these changes
May 18, 2023
|
@swift-ci please test source compatibility |
|
@swift-ci please test macOS platform |
|
|
|
|
angela-laar
pushed a commit
to angela-laar/swift
that referenced
this pull request
Jun 6, 2023
…sure-for-constrained-existentials Fix covariant erasure for constrained existentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constrained existential should be type erased to a dependent upper bound for parameterized protocols and generic classes.
Fixes rdar://101343646