[5.9🍒] rename _forget to discard; deprecate _forget
#65788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SE-390 concluded with choosing the keyword discard rather than forget for the statement that disables the deinit of a noncopyable type. This commit adds parsing support for `discard self` and adds a deprecation warning for `_forget self`. rdar://108859077
|
@swift-ci please test |
|
swiftlang/swift-syntax#1645 |
airspeedswift
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Description: Use the final accepted keyword
discardinstead of_forgetfor SE-390's new statement.• Risk: Low. Cond fail could happen, but I have a test confirming that it shouldn't since existing
_forget's get emitted as_forgetand will parse with just a warning.• Original PR: #65787
• Reviewed By: Ben Cohen
• Testing: tests included
• Resolves: rdar://108859077
Companion PR: swiftlang/swift-syntax#1645