[CodeCompletion] Fix ASAN failure when completing in parameter packs #65837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
xedin
approved these changes
May 10, 2023
| /// Indicies are based on the parameters in \c FuncTy. Note that the number | ||
| /// of parameters in \c FuncTy and \c FuncD is different when a parameter | ||
| /// pack has been exploded. | ||
| std::vector<bool> DeclParamIsOptional; |
There was a problem hiding this comment.
Maybe OptionalParams and you can use llvm::BitVector?
ahoppen
force-pushed
the
ahoppen/fix-asan-failure
branch
2 times, most recently
from
6ada5d6 to
9c6d31f
Compare
|
@swift-ci Please smoke test |
bnbarham
approved these changes
May 10, 2023
Whe completing in parameter packs, we were calling `getParameterAt` with `Res.FuncDeclRef`. But the substitution map in `Res.FuncDeclRef` contained type variables that were allocated in the constraint system’s arena. And that arena had been freed when we call this from `deliverResults`. The fix is to compute the optional parameters in advance in `sawSolutionImpl` rdar://109093909
ahoppen
force-pushed
the
ahoppen/fix-asan-failure
branch
from
9c6d31f to
9dd87e9
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whe completing in parameter packs, we were calling
getParameterAtwithRes.FuncDeclRef. But the substitution map inRes.FuncDeclRefcontained type variables that were allocated in the constraint system’s arena. And that arena had been freed when we call this fromdeliverResults.The fix is to compute the optional parameters in advance in
sawSolutionImplrdar://109093909