[Macros] Support module-qualified attached macro lookup #65863
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
requested review from
hborla,
xedin,
slavapestov,
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
|
@swift-ci please smoke test |
DougGregor
reviewed
May 11, 2023
|
This was explicitly discussed as part of the review of SE-0382 and rejected due to the syntactic ambiguity I pointed out. |
Allow attached macro expansion syntax to have a module qualifier, `@Foo.Bar`. rdar://108621205
rxwei
force-pushed
the
qualified-macro-108621205
branch
from
446bf5c to
893f10b
Compare
rxwei
changed the title
|
Reverted to just attached macros! |
|
@swift-ci please smoke test |
rxwei
commented
May 11, 2023
| @@ -8591,6 +8591,8 @@ class MacroDecl : public GenericContext, public ValueDecl { | |||
| /// declaration/expression nodes. | |||
| struct MacroExpansionInfo : ASTAllocated<MacroExpansionInfo> { | |||
| SourceLoc SigilLoc; | |||
| DeclNameRef ModuleName; | |||
There was a problem hiding this comment.
There's no syntactic change to macro expansion exprs/decls, but these two fields were added so that attached macros can continue to use the same code path in the constraint system to resolve macro refs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow attached macro expansion syntax to have a module qualifier, i.e.
@Foo.Bar.rdar://108621205