[Macros] Update for SwiftSyntaxMacroExpansion module #65882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Share the same expansion logic between ASTGen and SwiftCompilerMessageHandling
rintaro
requested review from
DougGregor and
bnbarham
and removed request for
CodaFi and
zoecarver
|
swiftlang/swift-syntax#1654 |
rintaro
changed the title
|
swiftlang/swift-syntax#1654 |
1 similar comment
|
swiftlang/swift-syntax#1654 |
bnbarham
reviewed
May 12, 2023
| guard let expansion = macroSyntax.asProtocol( | ||
| FreestandingMacroExpansionSyntax.self | ||
| ) else { | ||
| print("not on a macro expansion node: \(macroSyntax.debugDescription)") |
There was a problem hiding this comment.
I realize this was already here, but is there something else we could do here instead? We have the diagnostics engine, could we just output a diagnostic? Same with the NULL source location above. Also sometimes we return 1 and other times -1, is that on purpose? Not that it's actually used by the caller...
Happy for this to be a separate PR though, or at least an issue so we're tracking it.
bnbarham
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share the same expansion logic between
ASTGenandSwiftCompilerMessageHandling