[CAS] Teach swift-frontend to replay result from cache #65924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
akyrtzi,
nkcsgexi,
benlangmuir,
artemcm and
jansvoboda11
cachemeifyoucan
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
artemcm
approved these changes
May 22, 2023
| @@ -48,6 +48,13 @@ llvm::Expected<llvm::cas::ObjectRef> swift::createCompileJobBaseCacheKey( | |||
| SkipNext = true; | |||
| continue; | |||
| } | |||
| // FIXME: Use a heuristic to remove all the flags that affect output paths. | |||
| // Those should not affect compile cache key. | |||
| if (Arg.startswith("-emit-")) { | |||
| return None; | ||
| } | ||
| if (!*Lookup) { | ||
| Diag.diagnose(SourceLoc(), diag::output_cache_miss, OutputPath, |
There was a problem hiding this comment.
Going forward, should these remarks be being a flag of some sort?
There was a problem hiding this comment.
Yeah, we should guard them but at some point I will reconfigure all the flags. Currently I am thinking that:
- add
-compile-cachedriver option to turn on replay and output storing. -enable-caswill just be a frontend option to add a cas instance for various cas tasks, like cas based dependency scanning, cas fs, cas object file format, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach swift-frontend to replay cache results if there is a cache hit.